sirkitree / angular-directive.g-signin

:triangular_ruler: AngularJS Directive for Google Plus Sign-in Button
http://jeradbitner.com/angular-directive.g-signin/
148 stars 84 forks source link

ECONFLICT Unable to find suitable version for angular #52

Closed bralat closed 8 years ago

bralat commented 8 years ago

I kept getting this ECONFLICT Unable to find suitable version for angular error when i tried installing angular-directive.g-sign through bower. So I took a look at your code and realised it was dependent on an older version of angular. I decided to bypass bower, copy the google-plus-signin.js file and part of the demo file to my project before it worked.

I think making the directive compatible with angular 1.5.x or newer would fix the bower issue and prevent future frustrations

sirkitree commented 8 years ago

Thanks for the report. I don't use angular much theses days so my time maintaining this is sparse to say the least. Happy to review patches if you have modifications that have worked for you. Or did you simply drop it in and all we need to do is update the angular version in package.json? On Feb 28, 2016 10:13 AM, "crazyabdul" notifications@github.com wrote:

I kept getting this ECONFLICT Unable to find suitable version for angular error when i tried installing angular-directive.g-sign through bower. So I took a look at your code and realised it was dependent on an older version of angular. I decided to bypass bower, copy the google-plus-signin.js file and part of the demo file to my project before it worked.

I think making the directive compatible with angular 1.5.x or newer would fix the bower issue and prevent future frustrations

— Reply to this email directly or view it on GitHub https://github.com/sirkitree/angular-directive.g-signin/issues/52.

bralat commented 8 years ago

Yep! All you need to do is update the angular version and you are good to go. ;)

sirkitree commented 8 years ago

https://github.com/sirkitree/angular-directive.g-signin/commit/3f6c2f3e1ec609c857e4afa33ddc2b7069c49651