search

sirkris / Reddit.NET

A Reddit API library for .NET Standard with OAuth support. Written in C#.
MIT License
500 stars 77 forks source link

Updates everything to net6.0 framework. #172

Closed willWashington closed 1 year ago

willWashington commented 1 year ago

Not sure if there's a reason we can't upgrade this to 6.0. I made all the appropriate changes I believe and it all still seems to work correctly. I did not run the tests, but everything builds properly and I was able to retrieve my token with this configuration.

Please ping me if I need to remove the 6.0 stuff and just rely on the other updates. I think those can be implemented for sure. Let me know!

Refactors Program.cs in AuthTokenRetriever to assume most Chrome installations are 64bit. Refactors AuthTokenRetriverLib.cs to more adequately fulfill the exact match requirement based on the tutorial configuration. Executes code cleanup.

-Works for me locally, please do test fully before acceptance.

sirkris commented 1 year ago

.NET Standard is not legacy. We could support 5/6 by upgrading to .NET Standard 2.1, no refactoring needed. Refactoring to .NET 6 would severely degrade compatibility.