sirlan-ff00ff / arcticfox-theme

a theme for Firefox (and sidebery) to make it look and somewhat behave like Arc
Mozilla Public License 2.0
52 stars 2 forks source link

Theme support for Left sided Window Controls #15

Open sannidhyaroy opened 5 months ago

sannidhyaroy commented 5 months ago

I'm running Firefox on Fedora Workstation 39 and the the theme works fine (there are minor bugs but I don't really mind them), except the window controls placement. Since, I have the WhiteSur theme installed for Gnome and have the window controls on the left side using the Gnome Tweaks app, the back, forward and refresh buttons and the window controls buttons (close, minimize, maximize) overlap with each other. There is also this unwanted space on the right side after the menu button. Also, I did enable the mac_buttons.css by uncommenting in the userChrome.css file but the window controls doesn't seem to change. I don't know how to inspect the sidebar to edit the css, so can you point me out how I can get this to work properly? image

sannidhyaroy commented 5 months ago

Alright, I fixed the issues after digging into the css and trying my best to tweak it. I'll share the fix here, so others can try it if they experience the same issue.

sannidhyaroy commented 5 months ago

Don't know why the mac_button.css wasn't working for me, but I suspect it was probably because it was only tested with KDE Plasma Desktop Environment as per this #5 issue, whereas I was on Fedora running on Vanilla Gnome. One more thing to keep in mind is that second-last point in the solution that I shared above regarding the macOS Window Controls would only work if your Gnome Theme has the Window Controls from macOS (like I have WhiteSur GTK theme installed).

sirlan-ff00ff commented 3 months ago

(Sorry for the late response) if you want you could add the extra CSS and alternate width calculation as part of the repo, would be fine in having the alternate layout in the guide as well