search

sirmarcel / cmlkit

tools for machine learning in condensed matter physics and quantum chemistry
MIT License
34 stars 6 forks source link

Undefined behaviour in Dataset when filename is specified but not name #6

Open sxie22 opened 4 years ago

sxie22 commented 4 years ago

When a Dataset is created with no name but saved with a filename, references to that filename are ignored by certain other Components like tune.Run using a tune.TuneEvaluatorHoldout that was initialized with filenames for the train/test kwargs. Interestingly, EvaluatorHoldout.evaluate() does not suffer, while Run.run() does.

sirmarcel commented 4 years ago

Thanks! I think the reason that it shows up in Run is that on instantiation of the workers, it attempts to load the dataset by name (not filename), so it fails then.

I'll fix this by removing the filename option entirely! :D