sirocco-rt / sirocco

This is the repository for Sirocco, the radiative transfer code used to model winds in AGN and other systems
GNU General Public License v3.0
30 stars 24 forks source link

The routine that calculates the fractional convergence is failing #1061

Closed kslong closed 6 months ago

kslong commented 6 months ago

Although the plots associated with convergence appear to suggest that a high degree of convergence is achieved for the standard cv model, the convergence plot created be run_check.py indicates that much lower values of convergence are being achived.

The convergence plots are generated by reading the diagnostic files, but the values there do not appear to agree with what the final convergence plot (as a function of grid cell) is showing

As a guess this has to do with partial and complete celss.

kslong commented 6 months ago

Note - As an improvement it might be preferable if this kind of info were not stored in the diag file, but in a separate file (or the .sig file) since we do not really want to have to keep the diag files around

kslong commented 6 months ago

The issue here is that the convergence routine calculates convergence statistics for all plasma cells, and this will include any plasma cells that are only partially in the wind. Since our default now is to ignore cells that are partially in the wind, we get the wrong answer in cases where the number of partial cells is a large fraction of the total.

kslong commented 6 months ago

This should not be corrected. It is still the case that the statistics are written to the diagnostic files, and not a special file such as the .sig file, which might be desirable.