search

sirocco-rt / sirocco

This is the repository for Sirocco, the radiative transfer code used to model winds in AGN and other systems
GNU General Public License v3.0
30 stars 24 forks source link

Update communicate_plasma.c #1078

Closed jhmatthews closed 5 months ago

jhmatthews commented 6 months ago

Edit to length of communication buffer (NFORCE_DIRECTIONS) rather than (NUM_RAD_FORCE) in doubles. Also nions in ints.

jhmatthews commented 5 months ago

It looks to me like NFORCE_DIRECTIONS is the right one to use here (because it's the length of the variables being communicated - NUM_RAD_FORCE_DIRECTIONS is for dmo_dt instead. Although there are clearly issues here where other things have hardwired [4] allocations rather than being linked to NFORCE_DIRECTIONS, and potential for mistakes in calculating the buffer size.

jhmatthews commented 5 months ago

I will merge this, but may fix this up slightly afterwards.