sirocco-rt / sirocco

This is the repository for Sirocco, the radiative transfer code used to model winds in AGN and other systems
https://sirocco-rt.readthedocs.io/en/latest/
GNU General Public License v3.0
30 stars 24 forks source link

Eclipses/secondary stars don't work for BH systems #1085

Closed jhmatthews closed 5 months ago

jhmatthews commented 5 months ago

My understanding is that if you select "bh" in the parameter file then this should allow you to set up a binary that can absorb photons. Indeed this is implied by various if statements involving geo.binary == TRUE and the fact that

  if (geo.system_type == SYSTEM_TYPE_CV || geo.system_type == SYSTEM_TYPE_BH)
  {
    geo.binary = TRUE;
  }

in init_geo (). However, in main(), we have this statement

  /* Calculate parameters associated with the binary star system */

  if (geo.system_type == SYSTEM_TYPE_CV)
    binary_basics ();

which I think means the binary parameters are never set up in the BH case. I discovered this because there was no phase dependence in an XRB model I was calculating at high inc - when I look along the same phases and sightlines in a matched CV model they are absorbed by the secondary.

Proposed fix is just change to

  if (geo.binary)
    binary_basics ();
jhmatthews commented 5 months ago

This works after commit https://github.com/agnwinds/python/commit/8347fc542bace87317ece9996561c7ecde95e0c3 which implements the above fix.