sirocco-rt / sirocco

This is the repository for Sirocco, the radiative transfer code used to winds in AGN and other syatems
GNU General Public License v3.0
27 stars 24 forks source link

Proposed minimal banding change to prevent fewer than 7 ionization bands #1101

Closed jhmatthews closed 2 days ago

jhmatthews commented 1 week ago

This pull request (PR #1101) introduces updates to the banding strategy and other minor changes. Specifically:

Testing ongoing.

jhmatthews commented 2 days ago

Regression tests look good for this - I checked that nothing changes when you use TDE and AGN banding with matrix_pow. Things do change when you use TSTAR or CV banding with matrix_pow (as I expected from my changes), but overall the results look better, so I'm merging. The reporting is also helpful, if rudimentary.