Open kslong opened 4 years ago
@smangham I am just collecting up problems here. Ultimately we should fix all of them.
@smangham The changes to the .pf files in the notebook for reverb_low and reverb_high are identical. Please let me know immediately what they were supposed to be. I don't need you to do anything more at this, point, since I want to work through the whole script, before discussing what needs changing.
Apologies for missing this at the time.
The pip install -e .
mode (also Make install
in py_progs/py4py
) definitely works, and is what I'd recommend. I've added this to the py4py
README.md
file.
The justification for not including the reverb_low.pf
and reverb_high.pf
(and reverb_extended.py
) files is they need an internal line number, and that may change if the data files are altered. I'll put it in anyway. There's an open issue to make this less terrible. I've updated the notebook to replace the bash entries with cells with os.system
calls.
I think the missing variation on the low and high files has already been fixed- can't remember if I did it around when Matt hit this problem, or if someone else did. I think I'd just accidentally written Wind.mdot
instead of Disk.mdot
.
@smangham has provided a use case for reverberation mapping. This use case needs to be tested by others, and the results documented nere