Open ivan-krukov opened 7 years ago
This is the resolution for #17.
I had to change the way the module is imported. Now instead of
Rscript bin/make_ggplot2_functions.R >> pygg/pygg.py, one would
Rscript bin/make_ggplot2_functions.R >> pygg/pygg.py
Rscript bin/make_ggplot2_functions.R > pygg/ggplot2_functions.py
I think this is a little cleaner. It should also probably be added into the build script.
The functions are imported in __init__.py through a series of exec statements given the content of pygg/ggplot2_functions.py.
__init__.py
exec
pygg/ggplot2_functions.py
All of the above is to allows to cleanly import everything through __all__ without having to do from pygg import *, which would not work in py3.
__all__
from pygg import *
py3
The rest of the changes are of a cosmetic nature (print -> print(), etc.)
print -> print()
Thanks for a great module!
this is awesome! will take a look in the next day.
This is the resolution for #17.
I had to change the way the module is imported. Now instead of
Rscript bin/make_ggplot2_functions.R >> pygg/pygg.py
, one wouldRscript bin/make_ggplot2_functions.R > pygg/ggplot2_functions.py
I think this is a little cleaner. It should also probably be added into the build script.
The functions are imported in
__init__.py
through a series ofexec
statements given the content ofpygg/ggplot2_functions.py
.All of the above is to allows to cleanly import everything through
__all__
without having to dofrom pygg import *
, which would not work inpy3
.The rest of the changes are of a cosmetic nature (
print -> print()
, etc.)Thanks for a great module!