Initial cleanup and unit tests for pygg

sirrice / pygg

ggplot2 syntax in python. Actually wrapper around Wickham's ggplot2 in R

MIT License

73 stars 9 forks source link

Initial cleanup and unit tests for pygg #3

Closed depristo closed 9 years ago

depristo commented 9 years ago

Cleanup the code to fit autopep8 style (really indentation).
Fix bug in converting DataFrames to CSV files
Add unittest code functions that can be run with the command nosetest tests/ in the pygg root.
Add geom_smooth and ggtitle to commands

sirrice commented 9 years ago

Thank you for the pull request!

I'm looking for the dataframe bug fix, and the indentation makes everything a change. Do you mind pointing out the lines?

depristo commented 9 years ago

I refactored out a function is_pandas_df that now works. In the original code if you see the isinstance check is protected by a try catch block that catches all exceptions. Unfortunately that was catching the exception caused by referring to a missing variable (see o vs. df variable)

sirrice commented 9 years ago

Great. Look good to me!