Closed chelseaSchmidt closed 3 months ago
@sirrus233 Aaah been out all day and just had time to check this out, these review comments are so on point, dude thank you!! Gonna see if I can get a jump on these before we call tomorrow!
@sirrus233 I think I got everything, you want to take one more look?
Each time I change any of the math I wish for unit tests, and yet am too lazy to set up Jest. I will simply complain about it endlessly
Took a stab at this, check my logic though!
New budget inputs:
shipCapacityUsed
maxShipCapacity
spaceDockFighterBonus
New budget display field:
shipCapacityRemaining
:maxShipCapacity
+spaceDockFighterBonus
-shipCapacityUsed
- fighters added with the calculatorshipCapacityRemaining
shipCapacityRemaining
until it reaches 0, then they begin to count againstfleetSupplyRemaining
I realized there should also be a checkbox for "I'm building in a space-only system" for Saar (maybe others?), which would trigger ground forces to be subtracted from
shipCapacityRemaining
, but leaving that for another PR!