search

sirsavary / fastify-graphql

Run an Apollo Server on Fastify.
https://www.npmjs.com/package/fastify-graphql
MIT License
24 stars 5 forks source link

GraphQL version #5

Closed anacicconi closed 6 years ago

anacicconi commented 6 years ago

Hello,

I just noticed you require graphql on your dependencies. Is this really necessary? I don't see where it's used in the project. I just installed the 0.13 version of graphql in my project and I had to downgrade the version in order to use your plugin.

Thanks!

anacicconi commented 6 years ago

Hello,

I just saw you're using graphql for your tests. Sorry for the issue. However, I wasn't able to install the plugin because of the fastify-plugin version. Someone already did a PR to fix it:

https://github.com/sirsavary/fastify-graphql/pull/7

sirsavary commented 6 years ago

It's a devDependencys there shouldn't be an issue with it being listed. If for whatever reason installing this module brings GraphQL along with it and you're using yarn, use the "resolutions" section of your package.json to force a specific GraphQL version (see https://yarnpkg.com/en/docs/selective-version-resolutions).

Also, #7 has been merged. You should be good to go :)

anacicconi commented 6 years ago

Thanks for your reply @sirsavary !