sirskunkalot / PlanBuild

Valheim mod enabling you to plan buildings, copy structures and terraform
Do What The F*ck You Want To Public License
8 stars 13 forks source link

Generated Thumbnails too big for server download? | v0.81 #24

Closed himpich closed 2 years ago

himpich commented 2 years ago

I updated to v0.81 - love that new blueprint generation, really neat.

I re-generated all my blueprints via bp.regenthumbnails Then I uploaded all the blueprints with the new thumbnails to the server (via the blueprint stone). After that, my client crashes, if I try to load the list from the server:

Serverlog:

valheim-server 11/02/2021 22:59:32: Failed to send data k_EResultInvalidParam
valheim-server src/steamnetworkingsockets/clientlib/steamnetworkingsockets_connections.cpp (2076) : Assertion Failed: Message size 1147636 is too big.  Max is 524288

It looks a lot like that closed ticket: https://github.com/sirskunkalot/PlanBuild/issues/8

current blueprint files on the server:

# ls -lah
total 1.7M
drwxr-xr-x 2 root root 4.0K Nov  2 23:56  .
drwxr-xr-x 3 root root 4.0K Sep  9 11:23  ..
-rw-r--r-- 1 root root 1.3K Nov  2 23:56 'Blödbommel_BeeHive 1.blueprint'
-rw-r--r-- 1 root root  53K Nov  2 23:56 'Blödbommel_BeeHive 1.png'
-rw-r--r-- 1 root root 1.3K Nov  2 23:56 'Blödbommel_BeeHive 2.blueprint'
-rw-r--r-- 1 root root  51K Nov  2 23:56 'Blödbommel_BeeHive 2.png'
-rw-r--r-- 1 root root 1.4K Nov  2 23:56 'Blödbommel_BeeHive 3.blueprint'
-rw-r--r-- 1 root root  55K Nov  2 23:56 'Blödbommel_BeeHive 3.png'
-rw-r--r-- 1 root root 1.3K Nov  2 23:56 'Blödbommel_BeeHive 4.blueprint'
-rw-r--r-- 1 root root  56K Nov  2 23:56 'Blödbommel_BeeHive 4.png'
-rw-r--r-- 1 root root  72K Nov  2 23:55 'Blödbommel_Portalhub - Clean Version.blueprint'
-rw-r--r-- 1 root root  28K Nov  2 23:55 'Blödbommel_Portalhub - Clean Version.png'
-rw-r--r-- 1 root root  55K Nov  2 23:56 'Blödbommel_Wolfszuchtfarm - clean.blueprint'
-rw-r--r-- 1 root root  25K Nov  2 23:56 'Blödbommel_Wolfszuchtfarm - clean.png'
-rw-r--r-- 1 root root  23K Nov  2 23:56  farmhub.blueprint
-rw-r--r-- 1 root root  48K Nov  2 23:56  farmhub.png
-rw-r--r-- 1 root root  76K Nov  2 23:56  Fenrir_Sternbase.blueprint
-rw-r--r-- 1 root root  57K Nov  2 23:56  Fenrir_Sternbase.png
-rw-r--r-- 1 root root  39K Nov  2 23:56  FlokisModernHome.blueprint
-rw-r--r-- 1 root root  61K Nov  2 23:56  FlokisModernHome.png
-rw-r--r-- 1 root root 2.0K Nov  2 23:55  Glenmorangie_Portalhäuschen.blueprint
-rw-r--r-- 1 root root  49K Nov  2 23:55  Glenmorangie_Portalhäuschen.png
-rw-r--r-- 1 root root 5.2K Nov  2 23:56  Glenmorangie_Werkstatt.blueprint
-rw-r--r-- 1 root root 6.3K Nov  2 23:56 'Glenmorangie_Werkstatt DoD mit.blueprint'
-rw-r--r-- 1 root root  71K Nov  2 23:56 'Glenmorangie_Werkstatt DoD mit.png'
-rw-r--r-- 1 root root 6.0K Nov  2 23:56 'Glenmorangie_Werkstatt DoOrDie.blueprint'
-rw-r--r-- 1 root root  68K Nov  2 23:56 'Glenmorangie_Werkstatt DoOrDie.png'
-rw-r--r-- 1 root root  65K Nov  2 23:56  Glenmorangie_Werkstatt.png
-rw-r--r-- 1 root root  360 Nov  2 23:56  Glenmorangie_Wohnklo.blueprint
-rw-r--r-- 1 root root  54K Nov  2 23:56  Glenmorangie_Wohnklo.png
-rw-r--r-- 1 root root  634 Nov  2 23:56  Hørstsøn_Werkbankkiste.blueprint
-rw-r--r-- 1 root root  64K Nov  2 23:56  Hørstsøn_Werkbankkiste.png
-rw-r--r-- 1 root root 142K Nov  2 23:55  horst1.blueprint
-rw-r--r-- 1 root root  80K Nov  2 23:55  horst1.png
-rw-r--r-- 1 root root  35K Nov  2 23:55  Sinnloson_Lager.blueprint
-rw-r--r-- 1 root root  34K Nov  2 23:55  Sinnloson_Lager_holz.blueprint
-rw-r--r-- 1 root root  27K Nov  2 23:55  Sinnloson_Lager_holz.png
-rw-r--r-- 1 root root  27K Nov  2 23:55  Sinnloson_Lager.png
-rw-r--r-- 1 root root  26K Nov  2 23:55  Sinnloson_Starterhaus.blueprint
-rw-r--r-- 1 root root  52K Nov  2 23:55  Sinnloson_Starterhaus.png
-rw-r--r-- 1 root root  13K Nov  2 23:56  urhub.blueprint
-rw-r--r-- 1 root root  50K Nov  2 23:56  urhub.png

If you need more information or some testfiles, please let me know

sirskunkalot commented 2 years ago

Hi,

thanks for the report. I already feared that the bigger thumbnails may render my quick and dirty workaround useless. I am going to implement a real fix soon. Until then you will have to either disable server blueprints or make the list smaller. Sorry.

himpich commented 2 years ago

Maybe you can use the transfer method of the blueprints for the .png files as well? I seem to have some bigger blueprints, probably created with "that older planbuild mod thing" and AFAIK they work well

sirskunkalot commented 2 years ago

I guess for another workaround fix, I could send the blueprints one by one (atm it is sending out the whole list). But I wanted to make changes to Jötunn anyway which allow all mods to use compressed and sliced network sending. So I figured I won't postpone that any longer and use it in PlanBuild then.

sirskunkalot commented 2 years ago

Alright, implemented something in Jötunn. Sync should work again. It is painfully slow for multiple blueprints, though. I think I will just generate new thumbnails for server synced blueprints instead of pushing them including the thumbnail file in a future version. But for now it is fixed ;)

himpich commented 2 years ago

looking good, thanks