search

sirthias / pegdown

A pure-Java Markdown processor based on a parboiled PEG parser supporting a number of extensions
http://pegdown.org
Apache License 2.0
1.29k stars 218 forks source link

Updated taglist #169

Closed Deraen closed 9 years ago

Deraen commented 9 years ago

Replaces PR #164

I sorted the tag lists and added a test to check few tags. AST test is used as HTML tests are passed through jTidy which doesn't accept HTML5 tags.

martinklepsch commented 9 years ago

Maybe it makes sense to sort this programmatically as it would allow easier parsing by people reading the code if some hierarchy is maintained?

Deraen commented 9 years ago

Using hashset instead of sorted array and binary search should make sense.

Deraen commented 9 years ago

Okay, I reverted the order and used HashSet instead so the check should be fast still.

Friend mentioned using Enum might be good idea, with try/catch and valueOf it should be as fast to check if enum contains the string.

Deraen commented 9 years ago

I'm thinking hashset is the most reasonable solution for this.

martinklepsch commented 9 years ago

:+1:

martinklepsch commented 9 years ago

@sirthias ping :relaxed:

podviaznikov commented 9 years ago

+1 on this

martinklepsch commented 9 years ago

@sirthias please? :pray:

sirthias commented 9 years ago

Great. Thanks for this patch!

martinklepsch commented 9 years ago

@sirthias could we get a new release as well pleeeeeaaase? :)

sirthias commented 9 years ago

@vsch is still hammering away at a bunch of other issues and improvements. I'll publish a new release once he is done with his current spree of pegdown patches...

martinklepsch commented 9 years ago

@sirthias any chance you can give an update on when this will get released? :)

vsch commented 9 years ago

If you desperately need a new pegdown you can use the unofficial version from my vsc/idea-multimarkdown project in the lib section, which has all the PR's that were merged so far and the latest PR that is still pending. The build number is not official either, I increment it so I can keep track of changed versions for the plugin. However, if you need the update and can't wait it will solve your problem: https://github.com/vsch/idea-multimarkdown/blob/master/lib/pegdown-1.5.14.jar?raw=true

@sirthias is probably too busy these days and I can sympathize with him.

vsch commented 9 years ago

Forgot to mention that the source for the unofficial pedown jar is available from my fork: https://github.com/vsch/pegdown. It also has the updated readme for the new extensions.