search

sirthias / pegdown

A pure-Java Markdown processor based on a parboiled PEG parser supporting a number of extensions
http://pegdown.org
Apache License 2.0
1.29k stars 218 forks source link

fix images with no alt text #172

Closed kfang closed 9 years ago

kfang commented 9 years ago

fixes sirthias/pegdown#114

sirthias commented 9 years ago

Thanks for this patch! Are we missing a test that should have been red before and is now green?

kfang commented 9 years ago

Just looking into it now but it looks like there isn't a test with an empty alt?

kfang commented 9 years ago

Also, it looks like the recent merge of 1bffa457ed20177c5d766109b4c469831bbb2282 broke some tests so I'll try to get those sorted out.

vsch commented 9 years ago

All Tests passed when I ran them. Sometimes the first run of sbt test after source changes would report failed tests, however these would disappear when sbt test was invoked a second time.

kfang commented 9 years ago

thanks @vsch, I meant that the tests are broken on my branch :) Your fixes look good.

kfang commented 9 years ago

@sirthias not sure if there's a more clever way of fixing this. Lemme know if you have any better thoughts. Also added an empty image alt test.

sirthias commented 9 years ago

Thanks! Looks good!