search

sirthias / pegdown

A pure-Java Markdown processor based on a parboiled PEG parser supporting a number of extensions
http://pegdown.org
Apache License 2.0
1.29k stars 218 forks source link

Some Scala tests fail #188

Closed kyegupov closed 8 years ago

kyegupov commented 9 years ago 
[info] PegDownSpec
[info] 
[info] The PegDownProcessor should
[info] 
[info]   pass the custom pegdown tests for all extensions
[info]   x with the default parser
[error]      'RootNode [0-108]
[error]        HtmlBlockNode [0-88] '<figure>\n  <img src="foobar.jpg" alt="Foobar">\n  <figcaption>Foo</figcaption>\n</figure>'
[error]        HtmlBlockNode [89-108] '<aside>Foo</aside>'
[error]      '
[error]      
[error]       is not equal to 
[error]      
[error]      'RootNode [0-110]
[error]        HtmlBlockNode [0-89] '<figure>\n  <img src="foobar.jpg" alt="Foobar">\n  <figcaption>Foo</figcaption>\n</figure>'
[error]        HtmlBlockNode [89-110] '<aside>Foo</aside>'
[error]      ' (AbstractPegDownSpec.scala:76)
[info]  
[error] Expected: ...Node 0-1[10]
[error] ...Node 0-8[9]
[error] ...Node 89-1[10]
[info]  
[error] Actual:   ...Node 0-1[08]
[error] ...Node 0-8[8]
[error] ...Node 89-1[08]
[info]  
[info] 
[info]   x with a custom parser
[error]      'RootNode [0-108]
[error]        HtmlBlockNode [0-88] '<figure>\n  <img src="foobar.jpg" alt="Foobar">\n  <figcaption>Foo</figcaption>\n</figure>'
[error]        HtmlBlockNode [89-108] '<aside>Foo</aside>'
[error]      '
[error]      
[error]       is not equal to 
[error]      
[error]      'RootNode [0-110]
[error]        HtmlBlockNode [0-89] '<figure>\n  <img src="foobar.jpg" alt="Foobar">\n  <figcaption>Foo</figcaption>\n</figure>'
[error]        HtmlBlockNode [89-110] '<aside>Foo</aside>'
[error]      ' (AbstractPegDownSpec.scala:76)
[info]  
[error] Expected: ...Node 0-1[10]
[error] ...Node 0-8[9]
[error] ...Node 89-1[10]
[info]  
[error] Actual:   ...Node 0-1[08]
[error] ...Node 0-8[8]
[error] ...Node 89-1[08]
[info]
kyegupov commented 9 years ago

Maybe the original tests were checked under Windows, with \r\n line endings?

kyegupov commented 9 years ago

The proper fix would be better done at the text file reading stage (to make it like-end agnostic), which, unfortunately, happens inside paraboiled library.

sirthias commented 8 years ago

Closed by https://github.com/sirthias/pegdown/pull/189