make validation 'start' is set before 'end' in Activity

siruku6 / life_recorder

display activity log

MIT License

1 stars 2 forks source link

make validation 'start' is set before 'end' in Activity #36

Open siruku6 opened 3 years ago

siruku6 commented 3 years ago

I would like to invalidate the instance of activity model if start is later than end. But now, it is not as it.

reference (written in Japanese) https://noumenon-th.net/programming/2019/11/12/django-validation/

Deepanshusaxena1 commented 2 years ago

Hi @siruku6 , I want to work on this, Can you please assign this issue to me?

siruku6 commented 2 years ago

@Deepanshusaxena1 Hi ! Thank you for trying to work on this issue.

Please let me see your commit by pushing your branch, for example fix/#36, or making your pull request against my branch develop. I'm looking forward to your commit!

By the way, when do you think you can finish making first your pull request? I'll continue to assign you this issue at least until that time :wink:

Deepanshusaxena1 commented 1 year ago

Hi @siruku6

I have tried resolving this issue, can you please check this PR and do the needful?

PR: https://github.com/siruku6/life_recorder/pull/72

siruku6 commented 1 year ago

Thanks to @Deepanshusaxena1 , time-reversed data got blocked. But on UI it hasn't been easy to understand why that datum is invalid yet.

2023-04-30_16h25_45

I hope additional contributions to get the reason displayed on the page when time-reversed data is detected.