Hard Crop sizes in Settings > Media

sirulli / yoimages

Better image handling capabilities for Wordpress

http://sirulli.org/yoimages/

GNU General Public License v2.0

16 stars 10 forks source link

Hard Crop sizes in Settings > Media #12

Closed ferrbea closed 10 years ago

ferrbea commented 10 years ago

display every hard crop and resize formats even custom ones from theme settings in page settings > media No option to edit values but with explaination that says where you can go and crop them

fagia commented 10 years ago

Decide what to show in this page and how to display everything. For now both hard crops and resizes are displayed with different info, if it makes sense we can show only hard crops.

ferrbea commented 10 years ago

Let's write instead of hard crops and resizes what they really mean, even if it takes more words. As if we where explaining it to someone that doesn't know anything. I'll give it a try: Hard crop = image format cropped, e.g. thumbnail in listings are cropped Resize = image is not cropped but instead resized to fit the available space.

(please help me to come up with something better)

media-settings-sirullu-wordpress

fagia commented 10 years ago

Commit: a47ab3af47b571b4437bae7217402e386a1d4293 Added contextual help texts with javascript tooltips.

Wording when the active theme defines custom sizes:

"The sizes listed below are the crop and resize formats defined by "
Hard cropped -> "this image format contains only a part of the original image, it has fixed width and height so that the image ratio is fixed too, e.g. thumbnail in listings are cropped"
Resize -> "this image format is not cropped but instead it is resized to fit the maximum available space, either in width or height, therefore this image ratio is not fixed"

Wording when the active theme hasn't got any custom sizes:

" doesn't define any specific image size"

Please check wording and layout.

ferrbea commented 10 years ago

Current theme called FreeStyler - Responsive Creative WordPress Theme installed for test. in settings>media it says "FreeStyler - Responsive Creative WordPress Theme doesn't define any specific image size", but I have a listing page (blog listing) where thumbs are shown, which are resized not cropped. Shouldn't they show up in this page?

Wording and layout both look fine.

fagia commented 10 years ago

FreeStyler theme handles resizes and crops using its own custom functions, so the plugin cannot detect these custom formats since they aren't accessible from standard Wordpress APIs.

I've just changed the wording to better explain this case: _"[theme name] doesn't define any additional image size using the standard Wordpress functions (add_image_size and set_post_thumbnailsize)"

ferrbea commented 10 years ago

Shall we close this?