sirupsen / logrus

Structured, pluggable logging for Go.
MIT License
24.3k stars 2.26k forks source link

Fixes sirupsen/logrus#1434 - Update stretchr/testify to v1.9.0 to resolve 2 High sev vulnerabilities #1435

Open mcramer-billgo opened 3 weeks ago

mcramer-billgo commented 3 weeks ago

Fixes sirupsen/logrus#1434

mcramer-billgo commented 3 weeks ago

I'm not sure where the config for the windows AppVeyor runner is to make the version of GO set to 1.18. The updates here appear to require 1.18 as the minimum version. I've updated all the CI yaml files to use 1.18 as a minimum but still erroring in the windows runner.

dolmen commented 1 week ago

One do not change the minimum go version of a project just to fix a vulnerability in a remote dependency which is not even used in the project.

So this is not at all "2 high severity vulnerabilities". This PR is just FUD and completely useless.

Disclaimer: I'm one Testify co-maintainer.