Destroy not stopping the rendering or removing the WebGL context

sirxemic / jquery.ripples

Add a water ripple effect to your background using WebGL.

https://sirxemic.github.io/jquery.ripples/

MIT License

1.07k stars 418 forks source link

Destroy not stopping the rendering or removing the WebGL context #63

Closed GorelovNA closed 5 years ago

GorelovNA commented 5 years ago

@sirxemic Hi, I have a completely identical problem like on this issue (https://github.com/sirxemic/jquery.ripples/issues/37) - destroy method does not destroy the WebGL context behind itself. I use the latest version of the library. Can you fix it please? The library is awesome!

P.S. In the screenshot, manually initialize and destroy the element cyclically. It can be seen that after the some operation the browser throws a warning

sirxemic commented 5 years ago

Thanks for the report. Should be fixed now!

GorelovNA commented 5 years ago

Thanks for the report. Should be fixed now!

Thanks! Now it's great!