sirxemic / jquery.ripples

Add a water ripple effect to your background using WebGL.
https://sirxemic.github.io/jquery.ripples/
MIT License
1.06k stars 417 forks source link

Document the format of the resolution property #80

Closed rulatir closed 1 year ago

rulatir commented 3 years ago

Is it an array of numbers representing width and height? An object with width and height properties? A string like "1024x768"? What exactly does it mean if only one size is specified (since the default is said to be simply 256)?

rulatir commented 3 years ago

Misunderstood the description in the table, apparently it's just an integer and the texture is always square. But must it be a power of 2, or can it have any size?

sirxemic commented 3 years ago

That's a good point, it can be anything, but to make it work on most devices, it should be a power of 2 and not bigger than 2048.