sisby-folk / antique-atlas

A hand-drawn client-side minecraft world map with biomes, structures, waypoints, and less! A fourth-generation rewrite of Hunternif's Antique Atlas.
https://modrinth.com/mod/antique-atlas-4
Other
30 stars 11 forks source link

After rejoining a server modded biomes show up as "?" #123

Closed ItzLucaGER closed 4 months ago

ItzLucaGER commented 4 months ago

So I have a modded server with Regions Unexplored and if the player has not been on the server before the atlas shows the biomes normally but after a rejoin some of the RU biomes show up like this

Fabric Loader 0.15.11 Version is 1.20.1 AA version is 2.8.1 Surveyor Version on client and server is 0.5.0

Note: Client has AA and Surveyor Framework, server only has Surveyor. image

ItzLucaGER commented 4 months ago

Seems to work fine in singleplayer with the same world. Weird

ItzLucaGER commented 4 months ago

Adding AA to the server didn't change anything, just thought Id try that

ItzLucaGER commented 4 months ago

Another thing to note: It only shows the ? around the spawn. The same biomes are a few blocks further and just show normally on the atlas. image This is both the same biome but for whatever reason it looks like this (edit: when rejoining all the Regions Unexplored biomes become ?. When they get loaded on the Atlas for the first time they look normal, rejoining turns them all into ?)

After deleting the surveyor data on the client and rejoining it looks fine. But only until you rejoin again image

sisby-folk commented 4 months ago

sounds like some kind of race condition between biome tags loading and tiles loading - can you send your client logs/latest.log via https://mclo.gs/ ?

Also please check if the issue sticks with specific save data, even after completely closing and reopening the game - if that's the case, send me a zipped copy of data/surveyor and cite a chunk coordinate that appears as ? (use debug mode in the config)

ItzLucaGER commented 4 months ago

I closed and re-opened the game several times. Here is the log, I will do the other thing right now. https://mclo.gs/djliFOq

ItzLucaGER commented 4 months ago

Do you want me to turn on the "debugRender" option?

sisby-folk commented 4 months ago

That will help you get a sample chunk coordinate, yep.

ItzLucaGER commented 4 months ago

surveyor.zip Just picked a random chunk: 8,3 (128,51)

ItzLucaGER commented 4 months ago

Also I noticed when I restart the game and join for the first time it also renders normally, only after rejoining it happens.

sisby-folk commented 4 months ago

race issue:

image

image

tiles are loading before fallback biomes are set - this means that something in your modpack is causing tags to be serialized way later than they should (REI maybe?)

ItzLucaGER commented 4 months ago

REI is on the server and client, do I have to remove it on both to test it?

sisby-folk commented 4 months ago

worth a try, but honestly it's just a shot in the dark. I'll see if there might be some way to prevent atlas from loading before tags are in properly.

ItzLucaGER commented 4 months ago

I'll try and send the log again in a minute

ItzLucaGER commented 4 months ago

https://mclo.gs/eGfj9CS welp, its not REI

sisby-folk commented 4 months ago

It was REI - that log indicates that the tag-lag is gone - another reason to recommend EMI i'll remember lol. Still getting ?s though?

ItzLucaGER commented 4 months ago

Yes Im still getting the ?s, thats what I meant, my bad

sisby-folk commented 4 months ago

here's a version that holds off on generating any actual tiles until tags have been loaded antique-atlas-2.8.2+1.20.jar.zip - give that a shot.

ItzLucaGER commented 4 months ago

Will do, brb lol

ItzLucaGER commented 4 months ago

https://mclo.gs/9TMVOVr Works with REI, not getting any ?s anymore :D But since I am using the mod in a modpack on Modrinth I am gonna need permission to use this file, since this version isn't on Modrinth as far as I can see

ItzLucaGER commented 4 months ago

Otherwise I can also switch to JEI or EMI if that will fix it

sisby-folk commented 4 months ago

Hmm no I was mistaken - looks like your first connect didn't have the tag-lag, but the second one does? still might be another mod causing it, but regardless the fix will apply. Thanks for the help! that's published on modrinth now.

I do highly recommend EMI over REI in general! do look into it! but that's not related to this bug anymore :P

ItzLucaGER commented 4 months ago

no thank YOU for the help. Glad its fixed so fast :)

ItzLucaGER commented 4 months ago

also I just switched out REI for EMI and oh my god this is so much better xD