search

sisby-folk / antique-atlas

A hand-drawn client-side minecraft world map with biomes, structures, waypoints, and less! A fourth-generation rewrite of Hunternif's Antique Atlas.
https://modrinth.com/mod/antique-atlas-4
Other
30 stars 11 forks source link

Crash after palette rework in multiplayer only #143

Closed ItzLucaGER closed 3 weeks ago

ItzLucaGER commented 3 months ago

Game crashes after joining a server. After clearing out the /data/surveyor/ folder you can join just fine. If you then try to rejoin again it doesn't work.

https://mclo.gs/l5zjhTR

Not sure if its an AA or Surveyor issue tho. AA verison 2.9.1+1.20 Surveyor version 0.5.1+1.20

I should also say I updated surveyor on the server and client today. This didn't happen in 0.5.0 so it might be a surveyor issue

ItzLucaGER commented 3 months ago

I just reverted to surveyor 0.5.0 and it seems to be fine

ItzLucaGER commented 3 months ago

nvm some players still have the issue sometimes. Have to delete the folder everytime to join

sisby-folk commented 3 months ago

Looks like antique atlas is trying to poll the biome palette for a biome that doesn't exist. Since it only happens on rejoin, it could be an issue with syncing chunks. We'll look into this and see if we need more info.

annahla commented 3 months ago

this is also happening to me, but clearing out the surveyor folder doesn't work, and the crash happens at the block palette. it started right after updating a bunch of mods, so best guess is that it's due to a removal or addition of blocks or biomes across updates

rolling back does temporarily fix it, but then #134 still fucks shit up ofc

ItzLucaGER commented 3 months ago

Yes I also updated a bunch of mods, I rolled back surveyor and AA to the second newest version and it seems to be fine most of the time

TheD0ct0r101 commented 3 months ago

This seems to be the same issue members on my server are experiencing, however im not having this issue in singleplayer afaik

ItzLucaGER commented 3 months ago

could it be an issue with C2ME?

TheD0ct0r101 commented 3 months ago

could it be an issue with C2ME?

i dont imagine it should be, the error report seems to be purely related to antique atlas. But im no programmer so i could of course be wrong

Ethan-C-Honzik commented 3 months ago

Same issue here, just updated and now can't join my server worlds. I did confirm that C2ME wasn't causing the issue.

Ethan-C-Honzik commented 3 months ago

Should also mention I'm running terralith and tectonic together on 1.20.1

ItzLucaGER commented 3 months ago

its probably one of the mods everyone that has this issue is running that is incompatible with surveyor

sisby-folk commented 3 months ago

Do please post logs with any +1s, it does help.

For context, we switched to a strict palette system that crashes if a biome that wasn't originally in the registry on load is added. in this case, we're encountering a paletted biome index that isn't in the palette, which is even stranger.

We made a few fixes in 2.9.3 that are somewhat related, but nothing that would logically solve this issue.

Anyway what we actually need to resolve this is a minimum setup to reproduce the crash - smallest number of mods possible.

TheD0ct0r101 commented 3 months ago

Do please post logs with any +1s, it does help.

For context, we switched to a strict palette system that crashes if a biome that wasn't originally in the registry on load is added. in this case, we're encountering a paletted biome index that isn't in the palette, which is even stranger.

We made a few fixes in 2.9.3 that are somewhat related, but nothing that would logically solve this issue.

Anyway what we actually need to resolve this is a minimum setup to reproduce the crash - smallest number of mods possible.

I've confirmed the issue still occurs on the latest builds of Antique Atlas (2.9.3) and Surveyor (0.5.3) While its not exactly a minimal modlist, heres a crash log a server member from my modded server sent me message(9).txt

I also would like to confirm with you, is surveyor even needed? I ran Antique Atlas without Surveyor not long ago and it ran fine.

sisby-folk commented 3 months ago

in antique atlas 1.x the backend for antique atlas was inside antique atlas (saving, scanning, etc), in 2.x we completely deleted that and replaced it with surveyor, which we wrote for the purpose. So yep, from 2.0, completely required - it's what enabled the mod to be rebuilt as client-side at all.

sisby-folk commented 3 months ago

Anyway, you'll need to bisect to find the issue - without a minimum modset it's not possible for me to debug.

TheD0ct0r101 commented 3 months ago

in antique atlas 1.x the backend for antique atlas was inside antique atlas (saving, scanning, etc), in 2.x we completely deleted that and replaced it with surveyor, which we wrote for the purpose. So yep, from 2.0, completely required - it's what enabled the mod to be rebuilt as client-side at all.

Weird, I ran Antique Atlas 4 2.9.1 without Surveyor just fine. Ah well. Ill do some testing later

sisby-folk commented 3 months ago

Can you try this with surveyor 0.5.4? we've made a few corrections.

ItzLucaGER commented 3 months ago

Will do, does 0.5.4 need to be only on the server or client too?

sisby-folk commented 3 months ago

both

limelier commented 1 month ago

Also ran into a nether-related crash, like in #129. I'm not entirely sure if it's the same issue as this one, but it did match part of the crash log in #129.

Crashed when traveling to the nether on a multiplayer server. Also crash every time I try to reconnect. Clearing the Surveyor data did not seem to help.

I'm playing on 1.20.1, running AA4 2.9.13+1.20 and Surveyor 0.6.22+1.20 (also occurs on 0.6.21) on NeoForge 47.1.106 through Sinytra Connector 1.0.0-beta.44+1.20.1 along with a bunch of other mods.

crash-2024-08-23_16.43.51-client.txt

Still trying to figure out how to connect back to the server without removing Antique Atlas. Let me know if you need anything else.

edit: Tested in a singleplayer world, crash does not occur, even on the same seed and position.

limelier commented 1 month ago

Huh. I removed Antique Atlas temporarily so I could connect and exit the nether. Upon adding it back in, crash no longer occurs, even if I go to the nether.

limelier commented 1 month ago

I just had someone else go through similar steps (go to nether, crash, disable AA, rejoin, don't crash, re-enable AA) but it didn't work, they still crashed. Maybe removing and re-adding the surveyor data in-between made the difference for me?

edit: Okay, it seems a bit inconsistent. A second friend managed to go into the nether without an AA crash. Later, we both crashed due to unrelated reasons, and when we came back, both of us (him with no prior crashes, me with the workaround above) started crashing again.

edit 2: Yeah, I don't know. It looks like there's a way the crashes start (something related to coming into the nether? crashing while in the nether?), they continue for as long as AA is enabled in the nether, and then stop somehow (when you leave the nether, re-enable AA and come back? when you mess with the Surveyor data? not sure).

limelier commented 1 month ago

I made a PR to fix my problem - I don't think it's related to this issue after all. My bad.

sisby-folk commented 3 weeks ago

closing this in favour of #208