search

sisby-folk / inventory-tabs

A minecraft mod that allows swapping to other in-world screens (blocks, entities, etc) via tabs. A fourth-generation rewrite of CakeWhip's InventoryTabs.
https://modrinth.com/mod/inventory-tabs
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Expanded Storage Multiblocks #12

Closed lostopkk closed 8 months ago

lostopkk commented 8 months ago

https://github.com/sisby-folk/inventory-tabs/assets/50776714/ce0af3e3-47ae-4b92-9d66-017b1e778a48

I don't know if this bug where two tabs appear for the same chest only happens with expanded storage, but it's sad if you click on a part of the chest and it opens the same chest unnecessarily.

sisby-folk commented 8 months ago

Does this mod just have regular double chests? Or does it allow longer than double.

If these chests use the regular FACING and LEFT/RIGHT/SINGLE states that regular chests use, you should be able to set them to use the inventory_tabs:block_chest provider in the config.

If they use different properties than Vanilla chests, this will instead crash - meaning there needs to be a code integration.

sisby-folk commented 8 months ago

image

On investigation, expanded storage seems to allow chests to be doubled in any arbitrary direction, meaning the config change won't be sufficient. This can only be solved with an addon.

sisby-folk commented 8 months ago

Tried our hand at this over at expanded-storage#15

ghost commented 8 months ago

I'm sorry I had no clue y'all made a PR for this, I've just spent the last hour trying to implement it myself...

Would it be okay to manually pull the changes in and add you as a co-author?

ghost commented 8 months ago

Now implemented and released in Expanded Storage 10.1.0. Thanks again for PRing support which actually helped compatibility with Jade & similar projects. Will add to credits on Modrinth shortly.

sisby-folk commented 8 months ago

Thank you for carefully capitalising our name - happy modding!