search

sisby-folk / inventory-tabs

A minecraft mod that allows swapping to other in-world screens (blocks, entities, etc) via tabs. A fourth-generation rewrite of CakeWhip's InventoryTabs.
https://modrinth.com/mod/inventory-tabs
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Identifiers with periods break the config #25

Closed HaipaDev closed 7 months ago

HaipaDev commented 7 months ago

Great that you have a way of disabling certain blocks from appearing in the tabs. Because some are inventories without GUIs etc Just like the mod Tom's Simple Storage does have some.

And while its all good with for example the Packages mod, Tom's Storage has for no reason a subclass, all his blocks are under ts. so an example id is "toms_storage:ts.inventory_hopper_basic"

Well alright I input all of the incorrect blocks that shouldnt appear notepad++_RC0yALrMnf

On the first launch of the game it works correctly, it refreshes the list to apparently fix the formatting to work like this: xecNITb2Eu

But on the next reload, it for some reason reshuffles the list and now is broken MjQKOMmjgS

sisby-folk commented 7 months ago

Due to the nature of this, it's definitely an underlying bug in kaleido, or within its shadowed quiltconfig / nightconfigtoml. We'll see if anything can be done about this, because we'd certainly like all valid IDs to be usable as config values.

sisby-folk commented 7 months ago

Looks like there's an awareness of this issue upstream - we're looking into what can be done.

sisby-folk commented 7 months ago

fixed because quilt config fixed it and we bumped!

HaipaDev commented 7 months ago

Forgot to mention that was on 1.20.1 Fabric, do you know if its also fixed in this version or only on the newest?

sisby-folk commented 7 months ago

yep, tested on the 1.20.1 version - just update inventory tabs