search

sisby-folk / inventory-tabs

A minecraft mod that allows swapping to other in-world screens (blocks, entities, etc) via tabs. A fourth-generation rewrite of CakeWhip's InventoryTabs.
https://modrinth.com/mod/inventory-tabs
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Game crashes when opening inventory with Small Ships Mod #32

Closed 24-7-testing closed 7 months ago

24-7-testing commented 7 months ago

Minecraft version: 1.20.1 Mod version: Inventory Tabs v1.1.5+ Mod-Loader: Fabric

Description: When the Small Ships mod is installed (v2.0.0-b1.0), the game crashes when opening the inventory while piloting a ship. According to the creator of the Small Ships mod, it is an issue with Inventory Tabs not making a simple null check. Please investigate and update accordingly, if at all possible! Thank you!

Steps to reproduce: Enter ship as if to sail, press "E" to open inventory, observe crash.

Log: See attached. crash-2024-02-01_20.47.35-client.txt

sisby-folk commented 7 months ago

Looks like small ships is doing something we don't expect, like overriding the init functionality of its screen - we should be able to account for this with some extra safety checks as mentioned - expect it next hotfix!

24-7-testing commented 7 months ago

Awesome, thanks for the quick reply! I'll watch for the fix!

sisby-folk commented 7 months ago

up as 1.1.8 now - let us know if it works!

24-7-testing commented 7 months ago

It works, but now there is another small issue. I will make a separate issue report for it.