search

sisby-folk / inventory-tabs

A minecraft mod that allows swapping to other in-world screens (blocks, entities, etc) via tabs. A fourth-generation rewrite of CakeWhip's InventoryTabs.
https://modrinth.com/mod/inventory-tabs
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Tabs Are Misaligned With Small Ships Mod #33

Closed 24-7-testing closed 5 months ago

24-7-testing commented 7 months ago

Reference Issue #32 for most of the initial details. After the fix was applied, I checked to see if it worked. The game no longer crashes, but the tabs do not appear in the correct location. See pic attached. Tabs Misaligned

sisby-folk commented 7 months ago

This is back on Small Ships end now - they need to set their screen y to reflect the larger inventory panel instead of their small side panel (they can use their own custom field for that) - this is what inventory tabs uses to find the top left and width of the panel.

Here's the snippet:

image

24-7-testing commented 7 months ago

Good to know! I'll go file a report with them then. Thanks for the info!

sisby-folk commented 7 months ago

I'll note though, it seems like this screen doesn't properly support inventory tabs because of the aforementioned overriding of init() - you can tell because the "ship" tab icon isn't lit up indicating it's the current screen, and because of the previous crash issue.

For this, you can simply disable the screen in the inventory tabs config - feel free to read the part of the readme covering this.