search

sisby-folk / surveyor

Unified API, networking, and save data for minecraft map mods.
https://modrinth.com/mod/surveyor
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Block Palette OOB Crash #46

Open DaPuffer opened 2 months ago

DaPuffer commented 2 months ago

Mc version-1.20.1. Surveyor embedded in antique-atlas-2.9.13+1.20 version. Forge,Sinytra connector. I created a world,tried to remove a mod, tried to join the world afterwards and the game crashed on world loading at 0%. crash-2024-08-08_16.15.17-client.txt Tested with removing different mods and here's the results: Exposure:No crash Backpacked:Crash CreateDreams&Desires:Crash Infinity buttons:Crash Supplementaries:Crash really weird

sisby-folk commented 2 months ago

Thank you for this! I've been looking for a strong reproduction case for this issue and "uninstalling a mod that adds blocks" looks like it's right

DaPuffer commented 2 months ago

Thank you for this! I've been looking for a strong reproduction case for this issue and "uninstalling a mod that adds blocks" looks like it's right

The weird thing is that exposure does add a block. A single one- the lightroom,but it does not cause any issues

sisby-folk commented 2 months ago

that still makes sense - the block has to be both in the world, and in the position / having the properties that would cause it to be stored on the map (e. g. has map color, on surface)

sisby-folk commented 1 week ago

I am struggling to reproduce this even after i was sure this was the cause - I just generated a singleplayer world with BWG, removed BWG, and it ran:

image image

very proud of my repaletting code here as it seems to be doing great. Raises the question of when does this not work. Going to try some of the above listed mods.

sisby-folk commented 1 week ago

this is the underlying issue for https://github.com/sisby-folk/antique-atlas/issues/208 of course, for which all current reports appear to be on forge 1.20 so i might try that specifically - here's the three logs:

https://mclo.gs/AnznANw

https://mclo.gs/QLTrFqi

https://mclo.gs/hErwTm4

first two are in multiplayer though, which was my other clue - not sure.

sisby-folk commented 1 week ago

forge 1.21 with BOP and supplementaries, multiplayer.

Fine, placing some supplementaries blocks and then removing supplementaries, also fine:

image

deleting client-side map data and then reconnecting: also fine.

Genuinely, no idea how to reproduce this.