sisby-folk / switchy

A minecraft mod that combines player personalization features from other mods into presets.
https://modrinth.com/mod/switchy
GNU Lesser General Public License v3.0
12 stars 8 forks source link

Lost puppies can cause data loss / duplication in an edge case #38

Open sisby-folk opened 1 year ago

sisby-folk commented 1 year ago

Currently the data recovery system will load data straight back into modules when they're reinstalled, but that won't have any effect on the current preset.

What this means practically is that swapping the current preset while a module is uninstalled will cause you to copy data from the old current preset to the new one, erasing what was already there - both a data loss and dupe condition.

It's been a while since we've considered running applyToPlayer() on game start, so we don't remember whether it was just unneccesary or whether it was striaght-up impossible - but doing so would resolve the issue.