sisby-folk / switchy

A minecraft mod that allows switching between presets of player data (social profiles, rpg characters, etc) in a completetly modular way.
https://modrinth.com/mod/switchy
GNU Lesser General Public License v3.0
13 stars 8 forks source link

[Crash without log generating] Relating to spawn point module. [Fabric 1.20.1] #81

Open Dumpling00 opened 3 months ago

Dumpling00 commented 3 months ago

This is really weird. It didn't use to happen, so I'm thinking it might be some kind of conflict with another mod I'm using. I've tried this both in the latest version of Switch and the previous, but the issue persists:

Resetting your spawn point will make it so your game just force-quits itself after literally a few seconds, indenpendent of what you're doing. I've tried joining the world and just be on idle - game quits. This is ONLY happening when the spawn-point module is enabled. Everything works flawlessly once I disable it. I've had a four hour session without issues. Soon as I re-enabled the spawn-point module and reset my spawn point by clicking on another bed, the game just poofs. No crash report or nothing, it simply Alt-F4s itself.

I have spent the last week removing mods by category, but nothing seems to get rid of this issue.

Any educated guess would help a lot in troubleshooting this, but also maybe an update that forces a crash log for easier debug if at all possible. My guess is that something in my other mods is already messing with the way spawn points work, in a way that conflicts with Switchy, because this is definitely not an issue at Switchy's core, just some weird compatibility issue.

Please, help on this would be greately appreciated. Thank you for your time.

PS. Mod list provided below, divided into categories.

ModList Parsec.txt

sisby-folk commented 3 months ago

sounds like this issue?

Dumpling00 commented 3 months ago

It does! Except that in our case the game just quits without providing a crash log. Anything we can do to try and fix this? We'd like to keep the spawn module on.

sisby-folk commented 3 months ago

I think that's right - certain crashes don't produce logs, so the only useful information is in logs/latest.log

Can you see if you can make a clean reproduction case for this? minimum mods required for the crash, setup with a new world and presets.

Dumpling00 commented 3 months ago

So here's the thing - I have two separate modpacks, since I've already tried to debug this issue. The original modpack WITHOUT this issue has 276 mods. The one where this issue is present has 280. Most mods are the same.

The mods that are NOT in the working modpack that could possibly be creating the issue in the new pack are: -Dungeons and Taverns -Essential Dependencies -Formations Library, with Formation Overworld and Formation Nether -Illager Invasion -Immersive Structures -Shoulder Surfing -Towns and Towers -Unnamed Deserts -The Lost Castle

Most of these are structure related and I don't think it would make any sense for any of them to mess with the spawn. I'm mostly confused about Essential Dependencies now, however. Seems to be related to Fabric Language Kotlin, but the old modpack doesn't have this. It installed itself like any other normal dependency.

Pretty sure I've also tried removing all of these and still got the same issue, so any educated guess would be greatly appreciated and help a lot. Thank you again for your time!

Dumpling00 commented 3 months ago

I can also say that it doesn't seem to be related to any particular Origin as I've tried the most basic combinations (Human/Blacksmith, which always worked in the past) and I'm getting the issue with that as well.

Dumpling00 commented 3 months ago

Can confirm that the issue happens even after removing all of the above listed mods. Furthermore, I've made sure there are no version differences. So there is literally no reason why two identical modpacks would have this issue on one but not the other. Any clue would help. I've even tried deleting the files in .fabric ProcessedMods and let the pack rebuild itself, but absolutely nothing helps.

If this is one of those issues that are introduced by a random mod and persist even after disabling/removing said mod, this might take a while to hunt down. So again, any educated guess would be extremely appreciated. Please, I'm at my wits' end.

sisby-folk commented 3 months ago

maybe try thinking about it the other way? start with origins and teleport as specified and see if you can introduce the issue.

Dumpling00 commented 3 months ago

Will try to do that after work. At least the issue seems to be easily replicable. Thank you for your time again-

Dumpling00 commented 3 months ago

Alright, hello! Been doing a few more tests. It was easy enough to get "rid" of the issue, or at least confirm that it is indeed something affecting Teleport-Spawn, because even by disabling just the one mod, everything works fine. But we knew this was already the case by disabling the spawn point module.

So the assumption was, either some of the mods listed above were causing the crash to happen, or something else was at play. Since I had already tried disabling those mods and confirmed that the issue was still happening, I've decided on the following:

I've first tried this on a mirror instance: Made a duplicate of the modpack that was working fine and added those remaining mod, including the save file from the other world. Sure enough, the transplanted save file still crashes. Now, a premise: This mirror instance already has an older version of the same exact world in it, which now, because of the newly added mods, brings me this screen when trying to log in:

image

Fair enough. But here's what it says when I click on Proceed to let it apply the fixes.

image

Since this is relating to player data, I'm thinking the cause of the crash might be here, but I've tried deleting player data before and the issue still stands.

EDIT: I've tried deleting the player data just now and let it apply the fixes: it let me in the world, and as expected I crashed a few seconds in.

Thoughts?

Dumpling00 commented 3 months ago

Also, I had it working momentarily by doing this (Replicable) Uninstall Swichy Teleport Reload the game, enter world. Close the world. Reinstall Switchy Teleport Reload the game, enter world. Module is active, can reassign spawn points and play without crashing at all.

This as long as the session remains active. If I close the game and try again, I come back to crashing 5 seconds in.

The only remaining theory was to try this on a new world, so I just did and yeah. Crash 5 seconds in after enabling the spawn module and clicking on a bed or anything that resets your spawn point. This without even having other presets, just the default one.

Dumpling00 commented 3 months ago

Okay... so it does seem to be caused by "Dungeons and Taverns" For SOME reason.

sisby-folk commented 3 months ago

odd, does that work with a minimal mod set? and by work i mean crash

Dumpling00 commented 3 months ago

I'll try that - but at the moment there's another pressing matter involving switchy itself, since I've switched from Hosting the world through Essential to a local server - Switchy kicks me out of my own server every time I switch. Any idea why this is happening?

Console log here: https://gist.github.com/Dumpling00/9f41265307426704972d44a93262ebe2

Dumpling00 commented 3 months ago

odd, does that work with a minimal mod set? and by work i mean crash

Can confirm that the crash still happens even with just Switchy, Switchy Teleport and Dungeons & Taverns. But honestly it's fine, we're just leaving out Dungeons&Taverns for now. The issue listed above is more pressing I think.

sisby-folk commented 3 months ago

I see extremely little reason why that datapack would cause that crash, but i'll definitely try reproduce it on my side.

In terms of your other crash, pretty sure that's qouteall's dimlib? it's a qouteall package in the trace, and it says dim is null - just a guess.

Dumpling00 commented 3 months ago

I see extremely little reason why that datapack would cause that crash, but i'll definitely try reproduce it on my side.

In terms of your other crash, pretty sure that's quoteall's dimlib? it's a quoteall package in the trace, and it says dim is null - just a guess.

Not sure since dimlib seems to be 1.20.4 only and this issue I'm having now is on 1.20.1, not to mention it only seems to happen now after switching from Essentials Hosting to actual local server 🤔 how could we fix it?

Also worth mentioning, Dungeons & Taverns also has a mod version which is the one I was using.

sisby-folk commented 3 months ago

qouteall also makes immersive portals? you could check their mods, there, but, it's one of them.

also i can confirm that the dungeons and taverns mod doesn't have any code in it, so datapack is accurate. Again, unsure why it would be related - there aren't even any mcfunctions in it.

Dumpling00 commented 3 months ago

qouteall also makes immersive portals? you could check their mods, there, but, it's one of them.

also i can confirm that the dungeons and taverns mod doesn't have any code in it, so datapack is accurate. Again, unsure why it would be related - there aren't even any mcfunctions in it.

Oh wow okay I disabled immersive portal and I'm no longer kicked out when switching presets. This is really weird. Anything we can do to fix it? I can investigate the other glitch with Dungeons and Taverns, maybe there was something else at play.

sisby-folk commented 3 months ago

Set up a minimal instance with the smallest possible set of mods possible to produce the crash, then make a new world, produce the crash by hand, and post the latest.log - that gives us enough information to go on to investigate it properly.

Immersive portals does tend to cause a fair bit of incompatibility - you're really just not supposed to be in two dimensions at once for the most part, so it's not too surprising.

Dumpling00 commented 3 months ago

Set up a minimal instance with the smallest possible set of mods possible to produce the crash, then make a new world, produce the crash by hand, and post the latest.log - that gives us enough information to go on to investigate it properly.

Immersive portals does tend to cause a fair bit of incompatibility - you're really just not supposed to be in two dimensions at once for the most part, so it's not too surprising.

I mean fair enough on immersive portals but all the characters were sitting in the overworld and I would still be kicked out.