sisby-folk / tinkerers-smithing

A minecraft mod implementing a sentimental and convenient rebalance of minecraft gear crafting, repair, combining, and smithing.
https://modrinth.com/mod/tinkerers-smithing
GNU Lesser General Public License v3.0
4 stars 5 forks source link

About Curse of Binding #19

Closed FireSparkC closed 1 year ago

FireSparkC commented 1 year ago

The broken Curse of Binding Equipment has always occupied the equipment slot.If such equipment is equipped, there is no way to replace it.

sisby-folk commented 1 year ago

Genuinely not sure how to solve this one - Tinkerer's smithing expects that you can't lose enchanted items, but curse of binding expects that you can't keep them. "remove curse of binding entirely" seems too dramatic, but it's the only thing that would satisfy both properties.

FireSparkC commented 1 year ago

Genuinely not sure how to solve this one - Tinkerer's smithing expects that you can't lose enchanted items, but curse of binding expects that you can't keep them. "remove curse of binding entirely" seems too dramatic, but it's the only thing that would satisfy both properties.

I think you can try adding a more expensive consumable to destroy Broken Equipment or to eliminate the binding curses.

sisby-folk commented 1 year ago

I think the solution we're going to implement is that the binding curse doesn't work while the equipment is broken, and starts working again once it's repaired. ergo binding doesn't allow you to modify equipment for the full duration of its durability. This may cause issues for some mapmakers, but i'm happy with it.

FireSparkC commented 1 year ago

I think the solution we're going to implement is that the binding curse doesn't work while the equipment is broken, and starts working again once it's repaired. ergo binding doesn't allow you to modify equipment for the full duration of its durability. This may cause issues for some mapmakers, but i'm happy with it.

GOOD IDEA!

sisby-folk commented 1 year ago

Done in 2.5.1, credit to aquaholic for the idea - sorted.