search

sisby-folk / tinkerers-smithing

A minecraft mod implementing a sentimental and convenient rebalance of minecraft gear crafting, repair, combining, and smithing.
https://modrinth.com/mod/tinkerers-smithing
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Incompatibility with PushToCraft - recipeId is null #35

Closed ConqAra closed 6 months ago

ConqAra commented 8 months ago

Not able to run the mod with any versions that are 2.6.0+ (2.5.1 works just fine with my modpack)

Log: https://mclo.gs/y6sWPDf

sisby-folk commented 8 months ago

You'll have to bisect for this one, but the stack indicates it might be an issue with pushtocraft - can you check if it occurs without it?

ConqAra commented 8 months ago

Ah, its compatibility issue with Bouncy Life Ran fine when I removed it, I wonder why that's the case though? Odd.

sisby-folk commented 8 months ago

bouncy life includes pushtocraft, which seems to have the issue.

sisby-folk commented 6 months ago

I've reviewed this more extensively - We're calling Ingredient.fromJson(), which hits one of PushToCraft's hooks. That then expects a recipe ID to be not null, but our code is running before recipes are loaded, which is probably causing that to be not so.

Pushtocraft needs to add a null check - your log should provide plenty of context, so feel free to refile there.