search

sisby-folk / tinkerers-smithing

A minecraft mod implementing a sentimental and convenient rebalance of minecraft gear crafting, repair, combining, and smithing.
https://modrinth.com/mod/tinkerers-smithing
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Recipes break when using KubeJS #40

Closed mintynoura closed 7 months ago

mintynoura commented 7 months ago

So I'm using the mods on Quilt 1.20.1, and it seems that using startup scripts from KubeJS to modify or register anything (not necessarily related to anvils/smithing) will disable all the crafting and smithing recipes from Tinkerer's Smithing, as well as break the anvil repairing mechanics. Enchanting with books, combining tools, and using netherite scrap to reduce repair cost still work fine though

image

image

Neither the minecraft logs nor the KubeJS logs mention any errors

sisby-folk commented 7 months ago

The relevant mixins that kubejs must be breaking are SimpleResourceReloadMixin and/or RecipeManagerMixin.

In order to create data-driven recipes, Tinkerer's Smithing carefully registers its reloaders before recipes reload (which isn't exposed as an option by fabric api) - in all likelihood, kubejs is reordering reloaders after the fact, causing 0 recipes to be loaded.

We generally don't recommend kubejs precisely because its invasive patchset tends to break mods, so you can file the issue there if you like - there's nothing we can do on this side afaik.

mintynoura commented 7 months ago

That's a shame. Thank you for the quick response! I'll experiment with CraftTweaker and see if it works out