sisby-folk / tinkerers-smithing

A minecraft mod implementing a sentimental and convenient rebalance of minecraft gear crafting, repair, combining, and smithing.
https://modrinth.com/mod/tinkerers-smithing
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Help with compatibility datapack creation #54

Closed JotaFaD closed 4 days ago

JotaFaD commented 3 weeks ago

I'm creating a datapack to add compatility between this mod and Basic Weapons, which adds Daggers, Hammers, Clubs, Spears, Staffs and Glaives. I followed the structure here and got most weapons to work, with the exception of the Daggers.

Below is the file for glaives, which as you can see by the screenshot, are working.

tinkerers_smithing_basic_weapons\data\basicweapons\smithing_types\glaive.json
{
  "replace": false,
  "values": [
    "#c:tools/glaives"
  ]
}

image

And now the files for the daggers, which looks exactly the same, but doesn't work in game.

tinkerers_smithing_basic_weapons\data\basicweapons\smithing_types\dagger.json
{
  "replace": false,
  "values": [
    "#c:tools/daggers"
  ]
}

Strangely, I also tried creating a datapack for farmer's delight by copying the files in the source I linked above, but got the same problem with the knives. They don't work in-game.

I'm including my datapacks if you want to take a look. Any help is much appreciated.

datapacks.zip

sisby-folk commented 4 days ago

image

your datapack works for me just fine!

image

no issues in the log either - don't forget to manually add diamond unit costs for netherite items! you can see how here!

sisby-folk commented 4 days ago

Feel free to follow up with more info and we'll happily help out, i'm just keeping the tracker clean.