search

sisby-folk / tinkerers-smithing

A sentimental and convenient rebalance of minecraft gear crafting, repair, combining, and smithing.
https://modrinth.com/mod/tinkerers-smithing
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Partially incompatible with BCLib #7

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

MC 1.19.2 QSL 4.0.0-beta.16 Tinkerer's Smithing 1.0.1 (the problem exists on 1.0.0 as well) BCLib 2.1.2

When both mods are present, the smithing table changes don't apply, but everything else works as intended. 2022-10-23_14 41 39

There's another mod that changes what tools can be upgraded at the smithing table and that one works with BCLib, so reporting here first. Let me know if this needs to be reported to BCLib.

Logs: https://gist.github.com/SplendidAlakey/f6140570eec4af29dc28654093443d74

sisby-folk commented 1 year ago

Tinkerer's Smithing isn't a unique mod - it's just a datapack for NBTcrafting 2 - to that end, I'd specifically report an incompatibility between "nbt crafting smithing recipes" and BCLib, to BCLib (and nbt crafting too, if you like).

lxly9 commented 1 year ago

anvil recipes also do not work and bclib hasnt been updated since nor ahs it addressed the issue ;/

SplendidAlakey commented 1 year ago

@lxly9 seems like they have? https://github.com/quiqueck/BCLib/issues/45 + https://github.com/quiqueck/BetterEnd/issues/64

Gredys commented 1 year ago

@lxly9 seems like they have? quiqueck/BCLib#45 + quiqueck/BetterEnd#64

The problem still exists, while their issues are fixed.

Maybe its time to really dig up in this situation and check why its not worling like intended?

The mod is not usable in any way with most latest mod packs :/

sisby-folk commented 1 year ago

There's nothing really I can do about this one, please do make an issue on NBT crafting or BetterEnd's github issue page.

Gredys commented 1 year ago

There's nothing really I can do about this one, please do make an issue on NBT crafting or BetterEnd's github issue page.

How can we detect the source of the problem without debugging the mod?

Creating the ticket on their side with message like "The mod X is not working cos of your mod Y and you need to fix this is issue on your side" won't work without any usefull information, cos they are not developing your mod.

Mod owners, for most time, are talking with each other to fix compability issues like this one and not making users to talk for them :/

sisby-folk commented 1 year ago

it's not my mod, genuinely. this is just a datapack. I don't know how nbtc works internally I just write recipes.

On Fri, 5 May 2023, 8:15 am Gredys, @.***> wrote:

There's nothing really I can do about this one, please do make an issue on NBT crafting or BetterEnd's github issue page.

How can we detect the source of the problem without debugging the mod?

Creating the ticket on their side with message like "The mod X is not working cos of your mod Y and you need to fix this is issue on your side" won't work without any usefull information, cos they are not developing your mod.

Mod owners, for most time, are talking with each other to fix compability issues like this one and not making users to talk for them :/

— Reply to this email directly, view it on GitHub https://github.com/sisby-folk/tinkerers-smithing/issues/7#issuecomment-1535478901, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ34KKUWJK4MRLZDXCPDK3XEQTBLANCNFSM6AAAAAARMI5WK4 . You are receiving this because you modified the open/close state.Message ID: @.***>