search

sisl / AutoViz.jl

Provides visualization tools for AutomotiveDrivingModels. Built on Cairo
Other
33 stars 9 forks source link

Update function names due to changes by Tim in AutomotiveDrivingModel… #5

Closed sctchoi closed 7 years ago

sctchoi commented 7 years ago

…s.jl; see http://tinyurl.com/m3tannh

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 45.362% when pulling 537b1463d09dbbb4db63388fa64bfa83314cb038 on sctchoi:master into 88e011a39f58ca4c2bf30627ed1aabe42eeb3f39 on sisl:master.

tawheeler commented 7 years ago

Thank you for the PR. get_front_center was named to underscore the fact that if you have an oriented bounding box, the front point is not well defined. The front center point, however, is well defined. I agree that get_front is shorter and more convenient to write, and 99% of the time you want the front center anyway. Let's see if anyone has any issues with this.

sctchoi commented 7 years ago

If we do not change these function names, then get_front_center and get_rear_center are currently undefined in overlays.jl.

Sou-Cheng

On May 18, 2017, at 10:51, Tim Wheeler notifications@github.com wrote:

Thank you for the PR. get_front_center was named to underscore the fact that if you have an oriented bounding box, the front point is not well defined. The front center point, however, is well defined. I agree that get_front is shorter and more convenient to write, and 99% of the time you want the front center anyway. Let's see if anyone has any issues with this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.