search

sisl / AutomotiveDrivingModels.jl

Driving simulation architecture for Julia
Other
63 stars 29 forks source link

Compatibility with new version of Vec.jl #12

Closed MaximeBouton closed 6 years ago

MaximeBouton commented 6 years ago

The package can work with the new version of Vec.jl using StaticArrays. Changes were mostly replacing abs or abs2 by norm or normsquared.

I think I spotted one bug on the minkowski sum function in utils/minkowski.jl l145:

seg = get_edge(poly.pts, i)

instead of 

seg = get_edge(poly.pts, i, npts)

which prevent from accessing undefined reference in the poly.npts.

In the future, the ConvexPolygon type should probably be immutable.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 29.297% when pulling 4ca6369ed95c1c5f0e7ed23c921a95bd1e1f0eb8 on vec_compat into 74050e9ae44bda72a485c2573ac4f0df2bc3e767 on master.