search

sisl / AutomotiveDrivingModels.jl

Driving simulation architecture for Julia
Other
63 stars 29 forks source link

Bug in neighbor feature functions #36

Open Wang4758 opened 5 years ago

Wang4758 commented 5 years ago

Hi there,

In the function Base.get(::Feature_Dist_Front) and Base.get(::Feature_Dist_Rear)here, you can pass censor_hi as argument. But it is not used insided the function. Instead hard code values are used. Is that a bug?

MaximeBouton commented 5 years ago

I think you are right it seems like a bug. Could you submit a PR that fixes it and tests the function? The overall feature extraction part of the repo has not been tested thoroughly, do not hesitate to report bugs and contribute with fixes and tests.

MaximeBouton commented 4 years ago

70

MaximeBouton commented 4 years ago

the feature extraction mechanism has been redesigned see https://github.com/sisl/AutomotiveSimulator.jl