sisl / AutomotiveDrivingModels.jl

Driving simulation architecture for Julia
Other
63 stars 29 forks source link

`observe!` default is too specific #38

Closed MaximeBouton closed 4 years ago

MaximeBouton commented 4 years ago

I don't think we should provide a default for the observe! method and let it throw a method error when it is not implemented for a custom model.

https://github.com/sisl/AutomotiveDrivingModels.jl/blob/master/src/behaviors/interface.jl#L41

@mattuntergassmair

mattuntergassmair commented 4 years ago

Agreed, the current implementation was silently skipping the observe! function call and it was difficult for me to figure out I had not implemented that function for my specific types