sisl / AutomotiveDrivingModels.jl

Driving simulation architecture for Julia
Other
63 stars 29 forks source link

Example notebooks to docs #64

Closed mattuntergassmair closed 4 years ago

mattuntergassmair commented 4 years ago

Move IJulia example notebooks to the documentation folder, make sure plots are auto-generated when docs are created.

2DStadium has already been moved, remaining examples will be moved shortly. Eventually, all content will be migrated to the docs and IJulia notebooks and tutorials folder can be removed.

Fixes #62

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.4%) to 76.08% when pulling 8b1478357b38e931439062e01114b757f9f03643 on mattuntergassmair:notebooks_to_docs into 959ac684d3af273eb265379a7e77f7edba8eadbe on sisl:master.

MaximeBouton commented 4 years ago

Does this also includes change for AutoViz v0.8 or can it be merged directly?

MaximeBouton commented 4 years ago

oh I see that AutoViz is constrained to v0.8. We can close #59 then?

mattuntergassmair commented 4 years ago

oh I see that AutoViz is constrained to v0.8. We can close #59 then?

Ouh, I didn't see #59

But yes, this is for AutoViz v0.8.

Note that this PR is still work in progress, I just opened a PR so it could be reviewed on a rolling basis.

Maybe it is worth cross-checking this with #59 before merging

mattuntergassmair commented 4 years ago

Tim2DDriver and MOBIL were currently not working with new ADM interface. Fixed the implementations as part of this PR, even though it should technically have been a separate one. There are some deeper issues with FeatureExtraction which can be addressed in a separate PR.

MaximeBouton commented 4 years ago

The failing test is due to MOBIL

mattuntergassmair commented 4 years ago

The failing test is due to MOBIL

I was sloppy in replacing some of the extractor functions - should be fixed now

MaximeBouton commented 4 years ago

I think you need Reel in the docs/Project.toml

MaximeBouton commented 4 years ago

I don't understand why the documentation stage does not show up in travis...