Closed MaximeBouton closed 4 years ago
I have a first draft of the feature extraction working all the way. You can see the example in test/new_test_features.jl
.
My implementation is using a lot of broadcasting. Some stuff is not efficient, like constructing a dictionary all the times. If we only want to keep extract_features
as user facing, there might be some optimization possible in the lower level functions.
I decided to use dictionary instead of NamedTuples because it is a bit more flexible in terms of key types. If the ids are integer we cannot do df.1
.
cc @wbrannon @mattuntergassmair
This PR implements a new feature extraction mechanism and interface.
70
extract_features
function.DistanceTo(:bob)
,CollisionWith(:alice)
, ...). This is conflicting with the use of symbols and needs to be discussed.Most of the features from the previous version are implemented