Update to julia 0.6 - Githubissues

sisl / GridInterpolations.jl

Multidimensional grid interpolation in arbitrary dimensions

Other

52 stars 12 forks source link

Update to julia 0.6 #16

Closed MaximeBouton closed 7 years ago

MaximeBouton commented 7 years ago

Syntax changes for julia 0.6 compatibility
Modifications of the tests to use Interpolations.jl

coveralls commented 7 years ago

Coverage decreased (-0.01%) to 96.943% when pulling 6c7713dade705d0c9afd82eebaf23de97c6276ef on MaximeBouton:0_6 into da28d4bd350c411f4ffbcd4b71ec3d0e01cbb2fa on sisl:master.

MaximeBouton commented 7 years ago

julia 0.4 and 0.5 should be removed from the Travis config file

coveralls commented 7 years ago

Coverage decreased (-0.01%) to 96.943% when pulling 2dd6e35fc233b6650d5c7dc6932f37e502a09e1b on MaximeBouton:0_6 into da28d4bd350c411f4ffbcd4b71ec3d0e01cbb2fa on sisl:master.

mykelk commented 7 years ago

This looks good to merge. But, do the types need to be mutable struct rather than just struct?

MaximeBouton commented 7 years ago

According to julia 0.6 releases notes, type maps to mutable struct and immutable types map to struct. I haven't check if RectangleGrid and Simplex could actually be made immutable.

mykelk commented 7 years ago

We can keep them mutable. Let's go ahead and merge. You can push the button if you're good with it.

MaximeBouton commented 7 years ago

I do not have the access to merge it actually.

coveralls commented 7 years ago

Coverage decreased (-0.01%) to 96.943% when pulling 2dd6e35fc233b6650d5c7dc6932f37e502a09e1b on MaximeBouton:0_6 into da28d4bd350c411f4ffbcd4b71ec3d0e01cbb2fa on sisl:master.