search

sisl / GridInterpolations.jl

Multidimensional grid interpolation in arbitrary dimensions
Other
52 stars 12 forks source link

added grid iterator and access through cartesian indices #26

Closed mattuntergassmair closed 4 years ago

mattuntergassmair commented 4 years ago

implements iteration functionality from issue #14

coveralls commented 4 years ago

Coverage Status

Coverage increased (+1.8%) to 94.473% when pulling f07723b119459ce11716f5215b6212505f347c84 on mattuntergassmair:master into e4454061d6a3edb09788894f7d648780167922f0 on sisl:master.

MaximeBouton commented 4 years ago

Tests are failing on julia 0.7: https://travis-ci.org/sisl/GridInterpolations.jl/jobs/594904026 It seems to be a bounds error issue. If you see a fix go for it otherwise we can drop the support for 0.7.

On Travis we could add osx, windows and julia 1.2.

mattuntergassmair commented 4 years ago

@MaximeBouton I am not sure where the error is coming from exactly but my best guess is that it's a change of implementation of LinearIndices itself. The failing test uses two indices to index a 3d grid and expects a BoundsError, but it seems this is not thrown in julia <=v0.7

mattuntergassmair commented 4 years ago

Just added a condition to skip the test for v < 1.0

rejuvyesh commented 4 years ago

I think we can safely drop support for 0.7 now.