search

sisl / GridInterpolations.jl

Multidimensional grid interpolation in arbitrary dimensions
Other
52 stars 12 forks source link

Allocation Tests #50

Open zsunberg opened 1 month ago

zsunberg commented 1 month ago

This PR adds some allocation tests. Unfortunately they were failig.

zsunberg commented 1 month ago

@himanshugupta1009 didn't we get allocations down to zero with #42? I can't seem to reproduce the no-allocations

ctessum commented 1 month ago

I think the issue is that MArrays are sometimes allocated to the heap and sometimes allocated to the stack: https://stackoverflow.com/questions/74793823/mutable-data-types-that-use-stack-allocation

So the allocation tests seem to pass in some cases and fail in others, at least when I was trying it.

Unless there's some way to do the calculation with static arrays, the only thing I can think of is to add an interpolate!() method that that takes an object holding those MArrays as an argument, and another function that initializes those arrays. So then you could do the allocation ones and reuse the arrays a lot of times. Is that something there would be interest in?

zsunberg commented 1 month ago

Discussion continued in #51