search

sisl / Records.jl

Containers for object lists over time
Other
2 stars 2 forks source link

fixed malformed error for out of bounds access #8

Closed mattuntergassmair closed 4 years ago

mattuntergassmair commented 4 years ago

Want error to look like in the first case, not like the second case. Screenshot from 2020-01-21 17-10-59 Things remain unchanged if indexing by integers

codecov-io commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 1.91%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   88.51%   90.42%   +1.91%     
==========================================
  Files           7        7              
  Lines         296      303       +7     
==========================================
+ Hits          262      274      +12     
+ Misses         34       29       -5
Impacted Files Coverage Δ
src/frames.jl 93.82% <100%> (+1.32%) :arrow_up:
src/conversions.jl 97.5% <0%> (+0.13%) :arrow_up:
src/queuerecords.jl 58.97% <0%> (+1.07%) :arrow_up:
src/listrecords.jl 97.72% <0%> (+3.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57c633b...6f9564e. Read the comment docs.

MaximeBouton commented 4 years ago

Looks good, thanks! Should we tag a patch release? If there are other minor fixes that are needed let us know and we can tag them all together

mattuntergassmair commented 4 years ago

@MaximeBouton can we merge this?