Closed mattuntergassmair closed 4 years ago
Merging #8 into master will increase coverage by
1.91%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 88.51% 90.42% +1.91%
==========================================
Files 7 7
Lines 296 303 +7
==========================================
+ Hits 262 274 +12
+ Misses 34 29 -5
Impacted Files | Coverage Δ | |
---|---|---|
src/frames.jl | 93.82% <100%> (+1.32%) |
:arrow_up: |
src/conversions.jl | 97.5% <0%> (+0.13%) |
:arrow_up: |
src/queuerecords.jl | 58.97% <0%> (+1.07%) |
:arrow_up: |
src/listrecords.jl | 97.72% <0%> (+3.15%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 57c633b...6f9564e. Read the comment docs.
Looks good, thanks! Should we tag a patch release? If there are other minor fixes that are needed let us know and we can tag them all together
@MaximeBouton can we merge this?
Want error to look like in the first case, not like the second case. Things remain unchanged if indexing by integers