bugfix: wrong indexing in branch detecting

sisl / tufte_algorithms_book

A template for textbooks in the same style as Algorithms for Optimization

350 stars 66 forks source link

Closed BeastyBlacksmith closed 5 years ago

BeastyBlacksmith commented 5 years ago

I supposed your intention was to allow multiple spaces between package and version. Otherwise the version_pos2 can be replaced by version_pos.

johnnychen94 commented 5 years ago

Thanks for pointing out the bug. Yes as you may notice, this script is not fully tested.

As a replacement to this script, I think jlpkg is well maintained and works better than this one.

jlpkg --project=@ add $(cat requirements.txt) from https://github.com/fredrikekre/jlpkg/issues/4

mykelk commented 5 years ago

Thanks! Shall I merge this PR in for now, and someone can add the jlpkg functionality in a later PR?

johnnychen94 commented 5 years ago

Of course, you can merge it as you wish.