Closed marcnause closed 8 years ago
That's awesome! Thanks! :+1:
Oops, I just have a small Lint error, if you can look into it please:
:app:lintVitalRelease/var/jenkins_home/jobs/Reader_Android/workspace/reader-android/app/src/main/AndroidManifest.xml:72: Error: Resources referenced from the manifest cannot vary by configuration (except for version qualifiers, e.g. -v21.) Found variation in de [ManifestResource]
<meta-data android:name="description" android:value="@string/extension_description" />
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/jenkins_home/jobs/Reader_Android/workspace/reader-android/app/src/main/res/values-de/strings.xml:49: This value will not be used
Explanation for issues of type "ManifestResource":
Elements in the manifest can reference resources, but those resources
cannot vary across configurations (except as a special case, by version,
and except for a few specific package attributes such as the application
title and icon.)
/var/jenkins_home/jobs/Reader_Android/workspace/reader-android/app/src/main/res/values/arrays.xml:4: Error: "articlesFetched" is not translated in "de" (German) [MissingTranslation]
<string-array name="articlesFetched">
~~~~~~~~~~~~~~~~~~~~~~
/var/jenkins_home/jobs/Reader_Android/workspace/reader-android/app/src/main/res/values/arrays.xml:17: Error: "defaultSubscriptionsValues" is not translated in "de" (German) [MissingTranslation]
<string-array name="defaultSubscriptionsValues">
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/jenkins_home/jobs/Reader_Android/workspace/reader-android/app/src/main/res/values/arrays.xml:28: Error: "fontSizeValues" is not translated in "de" (German) [MissingTranslation]
<string-array name="fontSizeValues">
~~~~~~~~~~~~~~~~~~~~~
Explanation for issues of type "MissingTranslation":
If an application has more than one locale, then all the strings declared
in one language should also be translated in all other languages.
If the string should not be translated, you can add the attribute
translatable="false" on the <string> element, or you can define all your
non-translatable strings in a resource file called donottranslate.xml. Or,
you can ignore the issue with a tools:ignore="MissingTranslation"
attribute.
By default this detector allows regions of a language to just provide a
subset of the strings and fall back to the standard language strings. You
can require all regions to provide a full translation by setting the
environment variable ANDROID_LINT_COMPLETE_REGIONS.
You can tell lint (and other tools) which language is the default language
in your res/values/ folder by specifying tools:locale="languageCode" for
the root <resources> element in your resource file. (The tools prefix
refers to the namespace declaration http://schemas.android.com/tools.)
4 errors, 0 warnings
FAILED
My bad! I will create a new pull request for the changes that should remove the warnings above.
I have added a German translation for the strings in the Android app.