sissa-data-science / DADApy

Distance-based Analysis of DAta-manifolds in python
https://dadapy.readthedocs.io/
Apache License 2.0
99 stars 16 forks source link

Bug in MetricComparisons #108

Closed alexserra98 closed 5 months ago

alexserra98 commented 5 months ago

Subject of the issue

Hi, I'm rewriting to report a bug when calling return_data_overlap.py in metric_comparison.py

My environment

Steps to reproduce

data1=np.random.rand([1000,100]) data2=np.random.rand([1000,100]) mc = MetricComparisons(data1]) mc.return_data_overlap(data2, k = 20))

Error Message

File "/u/dssc/zenocosini/miniconda3/envs/crfm-helm/lib/python3.10/site-packages/dadapy/metric_comparisons.py", line 545, in return_data_overlap dist_indices2 = self._get_nn_indices(self.X, None, self.dist_indices) AttributeError: 'MetricComparisons' object has no attribute 'dist_indices'. Did you mean: 'distances'?

diegodoimo commented 5 months ago

Thank you, I'll have a look at that.