Closed alexserra98 closed 5 months ago
Thank you for the improvement. I'll have a look at the code in the next few days.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
5935c77
) 79.10% compared to head (5c17eb5
) 79.21%.
Files | Patch % | Lines |
---|---|---|
dadapy/metric_comparisons.py | 94.11% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
I've modified the method
from MetricComparisons() to support class imbalance.
Types of changes
The method now check for class imbalance and if True compute the overlap using a number $k$ of nearest neighbours that change as a function of number of elements per class. By default $k$ is set as $10$% of the class population but it can be modified with the argument k_per_classes.
Checklist